Description

The Bueno validation schema in AtomicColorFacet was instantiated in the constructor on every component creation. This refactors it to a private static readonly class member, following the pattern established in atomic-result-timespan.

Additionally, the headingLevel property documentation has been clarified to accurately reflect that a value of 0 is valid and renders a div instead of a heading element.

Changes

• Moved schema definition from constructor to private static readonly propsSchema class member
• Updated ValidatePropsController to reference AtomicColorFacet.propsSchema
• Updated headingLevel property documentation to clarify that 0 is a valid value that renders a div instead of a heading element

Before:

constructor() {
  super();
  new ValidatePropsController(
    this,
    () => ({...}),
    new Schema({...}),  // Created per instance
    false
  );
}

After:

private static readonly propsSchema = new Schema({...});  // Created once

constructor() {
  super();
  new ValidatePropsController(
    this,
    () => ({...}),
    AtomicColorFacet.propsSchema,
    false
  );
}

✅ Checklist

• 🧪 The component is unit tested
• 🧪 The component includes E2E tests
• 🗑️ Old Cypress tests exclusive to the component are removed
• 📖 The component is documented in storybook with an .mdx file
• ♿ The component complies with the Web Content Accessibility Guidelines.
• 🌐 All strings intended for humans or assistive technology must be localized with i18n.
• 📦 The Lit component is exported in the appropriate index.ts and lazy-index.ts files.
• 🎨 CSS parts are documented still accessible.
• 🦥 Slotted Content, public methods and properties are documented
• 🔄 The component outputs the same Angular output as before with Stencil
• 🏷️ The component declares the component type in the HTMLElementTagNameMap

Original prompt

---

This section details on the original issue you should resolve

[Atomic]: atomic-color-facet validation schema should be defined as private static readonly

Task Description

Right now a new instance of the Bueno validation schema object is re-created every time the AtomicColorFacet constructor is called, which is wasteful (especially if there are multiple atomic-color-facet components in the same page).

Follow the pattern in atomic-result-timespan and declare the propsSchema as a private static readonly member of the class instead.

Acceptance Criteria

• The atomic-result-timespan Bueno schema is declared as a private static readonly member of the class.
• The build passes.
• All tests pass without any modifications.

Technical Notes

Jira Ticket

No response

Comments on the Issue (you are @copilot in this section)

• Fixes [Atomic]: atomic-color-facet validation schema should be defined as private static readonly #6787

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Jira: KIT-5370